<html>
<head><meta charset="utf-8"><title>Contribution to chalk · wg-traits · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/index.html">wg-traits</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html">Contribution to chalk</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="191364418"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/191364418" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Super Tuple <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#191364418">(Mar 21 2020 at 20:31)</a>:</h4>
<p>Hi!</p>
<p><span class="user-mention" data-user-id="218710">@David Ross</span> and myself are interested in contributing to chalk over the next couple of weeks. We are planning to meet every Saturday to work on it. We were previously contributing to rustc but are interested in working on Chalk, as it is a little more approachable with our limited time.</p>
<p>We are planning to pick up some good first issues to get warmed up. However, we are hoping to eventually do something more substantial, does anyone have suggestions for an area we could focus on longer term?</p>



<a name="191537355"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/191537355" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#191537355">(Mar 23 2020 at 21:13)</a>:</h4>
<p><span class="user-mention" data-user-id="271698">@Super Tuple</span> I haven't missed this :) Was a busy weekend for me, so wasn't able to respond to this. Long story short, we are going to <em>probably</em> a few different things to work on for the next sprint (starting next Tuesday)</p>



<a name="191537392"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/191537392" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#191537392">(Mar 23 2020 at 21:13)</a>:</h4>
<p>Most of the things to do are somewhat centered around rustc integration</p>



<a name="191537566"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/191537566" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#191537566">(Mar 23 2020 at 21:15)</a>:</h4>
<p>I'll think about this more, but I we'll figure out more about what we plan to get done for the next 6 weeks tomorrow at the design meeting (4PM EST) if you want to join</p>



<a name="191541116"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/191541116" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#191541116">(Mar 23 2020 at 21:46)</a>:</h4>
<p>Yeah! This is exciting. <span class="user-mention" data-user-id="271698">@Super Tuple</span> and <span class="user-mention" data-user-id="218710">@David Ross</span> we can try to keep an eye out for some work items tomorrow -- would you both like to tackle the same problem, or perhaps two related problems?</p>



<a name="191566916"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/191566916" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Areredify <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#191566916">(Mar 24 2020 at 04:59)</a>:</h4>
<p>Hello! Since this topic has come up, I would like to say that I would be very excited to work on chalk as well, if possible</p>



<a name="192920715"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/192920715" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> David Ross <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#192920715">(Apr 04 2020 at 18:23)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116009">nikomatsakis</span> <a href="#narrow/stream/144729-wg-traits/topic/Contribution.20to.20chalk/near/191541116" title="#narrow/stream/144729-wg-traits/topic/Contribution.20to.20chalk/near/191541116">said</a>:</p>
<blockquote>
<p>Yeah! This is exciting. <span class="user-mention silent" data-user-id="271698">Super Tuple</span> and <span class="user-mention silent" data-user-id="218710">David Ross</span> we can try to keep an eye out for some work items tomorrow -- would you both like to tackle the same problem, or perhaps two related problems?</p>
</blockquote>
<p>Sorry we didn't get back on this! One item between us would be good.</p>
<p>I realize we missed the deadline for the pre-sprint meeting on March 24th - so if there isn't anything to be assigned that's understandable. If there's anything small or less blocking, though, would there still be an opportunity for next Tuesday?</p>
<p>We've also both enabled zulip notifications now! We'll try to be in better communication.</p>



<a name="192921046"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/192921046" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#192921046">(Apr 04 2020 at 18:31)</a>:</h4>
<p><span class="user-mention" data-user-id="218710">@David Ross</span>  checkout out this Hackmd  (<a href="https://hackmd.io/kYWsWI9IS0213x0qX_1RDw?both" title="https://hackmd.io/kYWsWI9IS0213x0qX_1RDw?both">https://hackmd.io/kYWsWI9IS0213x0qX_1RDw?both</a>) and see if there's anything you're interested in?</p>



<a name="192921052"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/192921052" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#192921052">(Apr 04 2020 at 18:31)</a>:</h4>
<p>There's plenty to do :)</p>



<a name="192922035"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/192922035" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> David Ross <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#192922035">(Apr 04 2020 at 18:57)</a>:</h4>
<p>Oh- awesome! A lot of those look interesting, but also daunting / open.</p>
<p>Do you know if anyone's working on creating a .chalk file from a given program?</p>



<a name="192922137"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/192922137" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#192922137">(Apr 04 2020 at 18:59)</a>:</h4>
<p>Yeah, some can definitely be daunting. But feel welcome to ask questions here!</p>



<a name="192922139"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/192922139" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#192922139">(Apr 04 2020 at 18:59)</a>:</h4>
<p>Nobody is currently working on that</p>



<a name="192922145"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/192922145" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#192922145">(Apr 04 2020 at 18:59)</a>:</h4>
<p>I have a branch somewhere where I <em>started</em> on that</p>



<a name="192922188"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/192922188" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#192922188">(Apr 04 2020 at 19:00)</a>:</h4>
<p>let me try to find it</p>



<a name="192922206"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/192922206" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mark McCaskey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#192922206">(Apr 04 2020 at 19:00)</a>:</h4>
<p><span class="user-mention silent" data-user-id="218710">David Ross</span> <a href="#narrow/stream/144729-wg-traits/topic/Contribution.20to.20chalk/near/192922035" title="#narrow/stream/144729-wg-traits/topic/Contribution.20to.20chalk/near/192922035">said</a>:</p>
<blockquote>
<p>Oh- awesome! A lot of those look interesting, but also daunting / open.</p>
</blockquote>
<p>Yeah, I feel the same -- I'm also interested in contributing here if I can but I'm not sure where to start.  I'm very comfortable with Rust but new to contributing to Rustc!</p>



<a name="192922211"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/192922211" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#192922211">(Apr 04 2020 at 19:00)</a>:</h4>
<p>(not saying it's going to be the <em>right</em> way to approach it, but would be a good start)</p>



<a name="192922438"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/192922438" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#192922438">(Apr 04 2020 at 19:06)</a>:</h4>
<p>Here is the branch: <a href="https://github.com/jackh726/chalk/commit/c43f1a1bf7446e5a71298395c300e257d504fc1e" title="https://github.com/jackh726/chalk/commit/c43f1a1bf7446e5a71298395c300e257d504fc1e">https://github.com/jackh726/chalk/commit/c43f1a1bf7446e5a71298395c300e257d504fc1e</a></p>



<a name="192922454"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/192922454" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#192922454">(Apr 04 2020 at 19:07)</a>:</h4>
<p>This was really just a start. Really, we would want it to be at the <code>chalk_ir</code> level, not <code>chalk_integration</code></p>



<a name="192922520"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/192922520" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#192922520">(Apr 04 2020 at 19:09)</a>:</h4>
<p><span class="user-mention" data-user-id="281304">@Mark McCaskey</span> did you look at the hackmd? Is there something in particular that piques your interest?</p>



<a name="192922536"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/192922536" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#192922536">(Apr 04 2020 at 19:09)</a>:</h4>
<p>If not, I can probably recommend a couple</p>



<a name="192922588"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/192922588" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#192922588">(Apr 04 2020 at 19:10)</a>:</h4>
<p>Generating .chalk files is indeed a good one to start with, as it doesn't require too much knowledge with how program clauses work under the hood, while giving a chance to get familiar with them</p>



<a name="192922598"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/192922598" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#192922598">(Apr 04 2020 at 19:11)</a>:</h4>
<p>(plus it will be super useful in general)</p>



<a name="192922781"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/192922781" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> David Ross <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#192922781">(Apr 04 2020 at 19:16)</a>:</h4>
<p>Cool! We'll start working on that then</p>



<a name="192922787"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/192922787" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mark McCaskey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#192922787">(Apr 04 2020 at 19:17)</a>:</h4>
<p><span class="user-mention" data-user-id="232957">@Jack Huey</span>  Yeah, the <code>impl trait</code> and unification of Rustc and Chalk types seem interesting! I found <a href="https://github.com/rust-lang/chalk/issues/368" title="https://github.com/rust-lang/chalk/issues/368">https://github.com/rust-lang/chalk/issues/368</a> and that actually seems like a good place to start -- thanks!</p>



<a name="192922835"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/192922835" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#192922835">(Apr 04 2020 at 19:18)</a>:</h4>
<p><span class="user-mention silent" data-user-id="218710">David Ross</span> <a href="#narrow/stream/144729-wg-traits/topic/Contribution.20to.20chalk/near/192922781" title="#narrow/stream/144729-wg-traits/topic/Contribution.20to.20chalk/near/192922781">said</a>:</p>
<blockquote>
<p>Cool! We'll start working on that then</p>
</blockquote>
<p>Awesome! Like I said, feel free to ask questions if you have any. I'll be around more on the weekends than <span class="user-mention" data-user-id="116009">@nikomatsakis</span></p>



<a name="192922870"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/192922870" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> David Ross <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#192922870">(Apr 04 2020 at 19:19)</a>:</h4>
<p>Will do, thanks! I guess I'll start a new zulip thread for that? Fairly new to the system</p>



<a name="192922875"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/192922875" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#192922875">(Apr 04 2020 at 19:19)</a>:</h4>
<p>Yeah, feel free</p>



<a name="192922877"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/192922877" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#192922877">(Apr 04 2020 at 19:19)</a>:</h4>
<p><span class="user-mention silent" data-user-id="281304">Mark McCaskey</span> <a href="#narrow/stream/144729-wg-traits/topic/Contribution.20to.20chalk/near/192922787" title="#narrow/stream/144729-wg-traits/topic/Contribution.20to.20chalk/near/192922787">said</a>:</p>
<blockquote>
<p><span class="user-mention silent" data-user-id="232957">Jack Huey</span>  Yeah, the <code>impl trait</code> and unification of Rustc and Chalk types seem interesting! I found <a href="https://github.com/rust-lang/chalk/issues/368" title="https://github.com/rust-lang/chalk/issues/368">https://github.com/rust-lang/chalk/issues/368</a> and that actually seems like a good place to start -- thanks!</p>
</blockquote>
<p>Yeah, adding type names is a good place to start! Same thing, if you have questions, feel free to ask</p>



<a name="192922926"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/192922926" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#192922926">(Apr 04 2020 at 19:20)</a>:</h4>
<p>I'll also <code>@rustbot assign</code> you both to the issues on github so we don't lose track</p>



<a name="192922961"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/192922961" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#192922961">(Apr 04 2020 at 19:22)</a>:</h4>
<p>Err, I actually don't know both of your github users. So feel free to <code>@rustbot claim</code> the issues :)</p>



<a name="192924100"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/192924100" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#192924100">(Apr 04 2020 at 19:51)</a>:</h4>
<p>I don't think the chalk repo is set up to let anyone do <code>rustbot claim</code>, but I've assigned the issues anyways <span aria-label="sweat smile" class="emoji emoji-1f605" role="img" title="sweat smile">:sweat_smile:</span></p>



<a name="192924413"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/192924413" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Super Tuple <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#192924413">(Apr 04 2020 at 19:59)</a>:</h4>
<p><span class="user-mention" data-user-id="125131">@detrumi</span> Thanks for assigning us. I deleted my <code>@rustbot claim</code> message in an attempt to remove noise, and that seems to have unassigned me. Could you re-assign me? Sorry :(</p>



<a name="192924421"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/192924421" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#192924421">(Apr 04 2020 at 19:59)</a>:</h4>
<p>haha</p>



<a name="192924479"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/192924479" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#192924479">(Apr 04 2020 at 20:00)</a>:</h4>
<p>I was very confused for a second. Of course!</p>



<a name="192924568"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/192924568" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#192924568">(Apr 04 2020 at 20:02)</a>:</h4>
<p>(makes sense: not everyone has permission to assign issues, but you can always unassign yourself)</p>



<a name="192926639"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/192926639" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#192926639">(Apr 04 2020 at 20:55)</a>:</h4>
<p>we recently set up the rustbot?</p>



<a name="192926681"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/192926681" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#192926681">(Apr 04 2020 at 20:56)</a>:</h4>
<p><a href="https://github.com/rust-lang/chalk/commit/328f6b74304eb87836ec501206b0e7b8da16dcad" title="https://github.com/rust-lang/chalk/commit/328f6b74304eb87836ec501206b0e7b8da16dcad">https://github.com/rust-lang/chalk/commit/328f6b74304eb87836ec501206b0e7b8da16dcad</a></p>



<a name="192926688"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/192926688" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#192926688">(Apr 04 2020 at 20:56)</a>:</h4>
<p>that's weird it didn't work</p>



<a name="192926704"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/192926704" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#192926704">(Apr 04 2020 at 20:57)</a>:</h4>
<p><span class="user-mention" data-user-id="232957">@Jack Huey</span> Can you point me to the issue where it didn't work?</p>



<a name="192926706"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/192926706" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#192926706">(Apr 04 2020 at 20:57)</a>:</h4>
<p>see <a href="#narrow/stream/144729-wg-traits/topic/triagebot" title="#narrow/stream/144729-wg-traits/topic/triagebot">https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/triagebot</a></p>



<a name="192926709"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/192926709" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#192926709">(Apr 04 2020 at 20:57)</a>:</h4>
<p><a href="https://github.com/rust-lang/chalk/issues/365#issuecomment-609079931" title="https://github.com/rust-lang/chalk/issues/365#issuecomment-609079931">https://github.com/rust-lang/chalk/issues/365#issuecomment-609079931</a></p>



<a name="192926712"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/192926712" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#192926712">(Apr 04 2020 at 20:57)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> ^</p>



<a name="192926760"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/192926760" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#192926760">(Apr 04 2020 at 20:58)</a>:</h4>
<p>I'll take a look</p>



<a name="192927181"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/192927181" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#192927181">(Apr 04 2020 at 21:09)</a>:</h4>
<p>okay, figured it out, rustbot needs to be added to the repo, doing so now</p>



<a name="193149966"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193149966" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193149966">(Apr 07 2020 at 07:38)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> <code>@rustbot claim</code> was assigning issues to rustbot, are we using it wrong or do we need to configure it? (this happened in <a href="https://github.com/rust-lang/chalk/issues/363" title="https://github.com/rust-lang/chalk/issues/363">https://github.com/rust-lang/chalk/issues/363</a> earlier)</p>



<a name="193153882"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193153882" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193153882">(Apr 07 2020 at 08:20)</a>:</h4>
<p>this is expected for some cases because of how github works: you can only assign issues to some people, like all the org members, not everyone. When it can, it'll assign like you'd expect, but when it can't, it'll "soft assign" via a comment on the first message in the issue: "This issue has been assigned to Areredify via this comment." like here</p>



<a name="193170960"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193170960" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193170960">(Apr 07 2020 at 11:16)</a>:</h4>
<p>Note also that GitHub has a bug in their API, once someone comments on an issue, they can be assigned, but I believe there's no way to do it through the API.</p>



<a name="193245987"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193245987" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193245987">(Apr 07 2020 at 20:48)</a>:</h4>
<p>weird</p>



<a name="193374313"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193374313" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cchndl <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193374313">(Apr 08 2020 at 20:28)</a>:</h4>
<p>Hey, since you mentioned it in yesterdays meeting:<br>
I wanted to ask which tasks I could help with, since I'm unsure where to start. I've done a little bit of rust in the last six months, read most of the blog posts and followed the messages in this stream for some weeks, but nonetheless I'm a little unsure, where exactly I can help/which tasks are not already worked upon.</p>



<a name="193411331"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193411331" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193411331">(Apr 09 2020 at 06:29)</a>:</h4>
<p>We have some chalk issues labeled <a href="https://github.com/rust-lang/chalk/labels/good%20first%20issue" title="https://github.com/rust-lang/chalk/labels/good%20first%20issue"><code>good first issue</code></a>, some of which are free to be picked up</p>



<a name="193411438"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193411438" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193411438">(Apr 09 2020 at 06:30)</a>:</h4>
<p>This is an easy one to start out with: <a href="https://github.com/rust-lang-nursery/chalk/issues/380" title="https://github.com/rust-lang-nursery/chalk/issues/380">chalk#380</a></p>



<a name="193411603"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193411603" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193411603">(Apr 09 2020 at 06:33)</a>:</h4>
<p>Looks like some of the others with that label are already being worked on. <a href="https://github.com/rust-lang-nursery/chalk/issues/306" title="https://github.com/rust-lang-nursery/chalk/issues/306">chalk#306</a> is still free, but looks a bit more difficult to start with</p>



<a name="193432684"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193432684" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Zahari Dichev <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193432684">(Apr 09 2020 at 10:37)</a>:</h4>
<p>You mind if I try and tackle <a href="https://github.com/rust-lang/chalk/issues/380" title="https://github.com/rust-lang/chalk/issues/380">https://github.com/rust-lang/chalk/issues/380</a> ?</p>



<a name="193436879"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193436879" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Areredify <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193436879">(Apr 09 2020 at 11:24)</a>:</h4>
<p>go ahead, first come first serve <span aria-label="upside down" class="emoji emoji-1f643" role="img" title="upside down">:upside_down:</span></p>



<a name="193449171"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193449171" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Zahari Dichev <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193449171">(Apr 09 2020 at 13:24)</a>:</h4>
<p>Nice! I would be interested in trying <a href="https://github.com/rust-lang-nursery/chalk/issues/306" title="https://github.com/rust-lang-nursery/chalk/issues/306">https://github.com/rust-lang-nursery/chalk/issues/306</a> too but if it is significantly harder, then I might need a bit more hand holding. Then again..  this is how you learn I guess :)</p>



<a name="193508610"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193508610" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Zahari Dichev <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193508610">(Apr 09 2020 at 21:00)</a>:</h4>
<p>I guess the chalk book is a good start for this one</p>



<a name="193511696"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193511696" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193511696">(Apr 09 2020 at 21:29)</a>:</h4>
<p><span class="user-mention" data-user-id="283967">@Zahari Dichev</span> so, for that issue</p>



<a name="193511734"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193511734" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193511734">(Apr 09 2020 at 21:29)</a>:</h4>
<p>I think we just want to add Floundering if the <code>Environment</code> gets too large</p>



<a name="193511950"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193511950" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193511950">(Apr 09 2020 at 21:31)</a>:</h4>
<p>Here: <a href="https://github.com/rust-lang/chalk/blob/master/chalk-solve/src/solve/slg.rs#L356" title="https://github.com/rust-lang/chalk/blob/master/chalk-solve/src/solve/slg.rs#L356">https://github.com/rust-lang/chalk/blob/master/chalk-solve/src/solve/slg.rs#L356</a></p>



<a name="193512064"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193512064" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193512064">(Apr 09 2020 at 21:32)</a>:</h4>
<p>but actually, we definitely don't want to accidentally leak that environment truncation, if we ever add truncation back in</p>



<a name="193512083"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193512083" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193512083">(Apr 09 2020 at 21:32)</a>:</h4>
<p>so, this might be worth blocking on making the truncation a <code>Visitor</code></p>



<a name="193512170"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193512170" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193512170">(Apr 09 2020 at 21:33)</a>:</h4>
<p>at the very least, <code>truncate_goal</code> should be changed to have a return type of <code>Result&lt;(), Floundered&gt;</code></p>



<a name="193512240"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193512240" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193512240">(Apr 09 2020 at 21:34)</a>:</h4>
<p>if no overflow, return <code>Ok(())</code>. Otherwise, returned <code>Err(Floundered)</code></p>



<a name="193512307"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193512307" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193512307">(Apr 09 2020 at 21:35)</a>:</h4>
<p>note that this <em>might</em> make some tests ambiguous where we found an answer before</p>



<a name="193512688"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193512688" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193512688">(Apr 09 2020 at 21:39)</a>:</h4>
<p>Side thought: (c.c. <span class="user-mention" data-user-id="116009">@nikomatsakis</span>) I actually <em>do</em> think it would be useful to add truncation back in, in some form (eventually). Right now, we disallow goals like <code>Vec&lt;Vec&lt;Vec&lt;....&lt;T&gt;...&gt;&gt;&gt;</code> by just checking the type size. But when we potentially have to deal with large types (think maybe like a chain iterator), we would have to set that limit large. But we don't want to recurse into that <code>Vec...</code> that deep.</p>



<a name="193513152"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193513152" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193513152">(Apr 09 2020 at 21:43)</a>:</h4>
<p>I'm curious how the recursive solver might change this or not need it</p>



<a name="193541943"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193541943" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193541943">(Apr 10 2020 at 06:35)</a>:</h4>
<p>You'd only need to expand such goals if there are rules that nest <code>Vec</code> that deeply, otherwise it shouldn't be necessary to go further than the first step</p>



<a name="193778236"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193778236" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Zahari Dichev <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193778236">(Apr 13 2020 at 14:39)</a>:</h4>
<p><span class="user-mention" data-user-id="232957">@Jack Huey</span> thanks a lot. I submitted an issue to  avoid leaking the truncated result. Wrt to making the truncation a visitor. Is there an issue for that one that I can pick up ?</p>



<a name="193780391"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193780391" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Areredify <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193780391">(Apr 13 2020 at 15:00)</a>:</h4>
<p>Sorry, I might've (definitely) introduced a bunch of merge conflicts in your pr :P</p>



<a name="193780857"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193780857" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Zahari Dichev <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193780857">(Apr 13 2020 at 15:05)</a>:</h4>
<p>Yeah, I am not sure my PR is actually relevant anymore. No worries, will find something else.</p>



<a name="193788333"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193788333" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193788333">(Apr 13 2020 at 16:12)</a>:</h4>
<p>Hi <span class="user-mention" data-user-id="283967">@Zahari Dichev</span>, see my comment: <a href="https://github.com/rust-lang/chalk/pull/392#issuecomment-612967074" title="https://github.com/rust-lang/chalk/pull/392#issuecomment-612967074">https://github.com/rust-lang/chalk/pull/392#issuecomment-612967074</a></p>



<a name="193788414"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193788414" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193788414">(Apr 13 2020 at 16:13)</a>:</h4>
<p>tldr: these changes are superseded by the visitor change, but you can change it to solve <a href="https://github.com/rust-lang/chalk/issues/306" title="https://github.com/rust-lang/chalk/issues/306">rust-lang/chalk#306</a></p>



<a name="193814598"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193814598" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Zahari Dichev <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193814598">(Apr 13 2020 at 20:02)</a>:</h4>
<p>Thanks a lot !</p>



<a name="193945524"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193945524" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Zahari Dichev <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193945524">(Apr 14 2020 at 19:24)</a>:</h4>
<p><span class="user-mention" data-user-id="232957">@Jack Huey</span> I was wondering whether there is anything else that I can take on that can be a nice intro to the codebase?</p>



<a name="193947101"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193947101" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Areredify <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193947101">(Apr 14 2020 at 19:38)</a>:</h4>
<p>Stick around for the meeting, we will find something cool</p>



<a name="193947127"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193947127" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193947127">(Apr 14 2020 at 19:38)</a>:</h4>
<p>yes, that</p>



<a name="193947130"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193947130" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193947130">(Apr 14 2020 at 19:38)</a>:</h4>
<p>or</p>



<a name="193947164"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193947164" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193947164">(Apr 14 2020 at 19:39)</a>:</h4>
<p>see this: <a href="#narrow/stream/144729-wg-traits/topic/more.20issues/near/193669641" title="#narrow/stream/144729-wg-traits/topic/more.20issues/near/193669641">https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/more.20issues/near/193669641</a></p>



<a name="193947206"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193947206" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193947206">(Apr 14 2020 at 19:39)</a>:</h4>
<p>Let me see if I can narrow that done to a couple that are especially good</p>



<a name="193947434"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193947434" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193947434">(Apr 14 2020 at 19:41)</a>:</h4>
<p>Is there something in particular that you're interested in?</p>



<a name="193947881"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193947881" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193947881">(Apr 14 2020 at 19:46)</a>:</h4>
<p>If you want to do a little investigation (which would help you have a "goal" when looking around through the codebase bit), then <a href="https://github.com/rust-lang/chalk/pull/331" title="https://github.com/rust-lang/chalk/pull/331">this</a> PR/issue would be good</p>



<a name="193947893"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193947893" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193947893">(Apr 14 2020 at 19:46)</a>:</h4>
<p><span class="user-mention" data-user-id="283967">@Zahari Dichev</span></p>



<a name="193947940"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193947940" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193947940">(Apr 14 2020 at 19:46)</a>:</h4>
<p><span class="user-mention" data-user-id="129457">@Florian Diebold</span> has a fix there, but I have a hunch that there might be something subtle happening</p>



<a name="193948023"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193948023" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193948023">(Apr 14 2020 at 19:47)</a>:</h4>
<p>But looking over it again, it also just might be because of the way we handle <code>Floundering</code></p>



<a name="193948341"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193948341" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Zahari Dichev <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193948341">(Apr 14 2020 at 19:50)</a>:</h4>
<p><span class="user-mention" data-user-id="232957">@Jack Huey</span>  I will look at it nevertheless, it certainly will result in me learning something new. But anything else you can think of that is a good way to get familiar with the core concepts will probably be great. I am quite interested in the performance work that will mostly likely happen at some point. Kind of feel that I need a bit more breadth and depth before I can have a meaningful stab at it though. Hence looking for some more "getting familiar issues"</p>



<a name="193948441"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193948441" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Zahari Dichev <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193948441">(Apr 14 2020 at 19:51)</a>:</h4>
<p><span class="user-mention" data-user-id="251766">@Areredify</span> I will not be able to stick around for the meeting unfortunately (its getting a bit late here), but if you could pretend I am there, that will be much appreciated ;)</p>



<a name="193948483"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193948483" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193948483">(Apr 14 2020 at 19:51)</a>:</h4>
<p>Yeah, if you want to start with this, let's investigate and figure out if merging this PR is good or if there's a different/additional fix needed.</p>



<a name="193948512"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193948512" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193948512">(Apr 14 2020 at 19:51)</a>:</h4>
<p>Then after that, I can mentor you through performance-related work :)</p>



<a name="193948663"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193948663" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193948663">(Apr 14 2020 at 19:52)</a>:</h4>
<p>Specifically, for this issue/PR, I would start by pulling Florian's branch, rebase, and making sure the that the added test and the test in the comments both pass</p>



<a name="193948703"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193948703" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193948703">(Apr 14 2020 at 19:53)</a>:</h4>
<p>It seems like the one in the comments doesn't? <span class="user-mention" data-user-id="129457">@Florian Diebold</span></p>



<a name="193948898"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193948898" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193948898">(Apr 14 2020 at 19:54)</a>:</h4>
<p>Just created <a href="https://github.com/rust-lang/chalk/issues/397" title="https://github.com/rust-lang/chalk/issues/397">https://github.com/rust-lang/chalk/issues/397</a> which might be a good first issue</p>



<a name="193948921"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193948921" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Zahari Dichev <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193948921">(Apr 14 2020 at 19:54)</a>:</h4>
<p>Perfect, will look at them both !</p>



<a name="193958263"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193958263" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Florian Diebold <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193958263">(Apr 14 2020 at 21:17)</a>:</h4>
<p><span class="user-mention silent" data-user-id="232957">Jack Huey</span> <a href="#narrow/stream/144729-wg-traits/topic/Contribution.20to.20chalk/near/193948703" title="#narrow/stream/144729-wg-traits/topic/Contribution.20to.20chalk/near/193948703">said</a>:</p>
<blockquote>
<p>It seems like the one in the comments doesn't? <span class="user-mention silent" data-user-id="129457">Florian Diebold</span></p>
</blockquote>
<p>With my change, it produces the wrong result, yeah. I don't think it's really <em>caused</em> by my change though (I don't think <code>peek_answer</code> should change the behavior in that way?), rather that makes it hit that edge case. I added the second test to the PR, with the currently wrong result so it passes</p>



<a name="193958367"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193958367" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193958367">(Apr 14 2020 at 21:18)</a>:</h4>
<p>Right, this is basically what I said in the comments</p>



<a name="193958383"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193958383" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193958383">(Apr 14 2020 at 21:18)</a>:</h4>
<p>that I think there's something else happening here</p>



<a name="193958594"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Contribution%20to%20chalk/near/193958594" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Florian Diebold <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Contribution.20to.20chalk.html#193958594">(Apr 14 2020 at 21:20)</a>:</h4>
<p>yes, I think the "answer cached" case in <code>any_future_answer</code> is wrong</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>